Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-1464

StatisticsServlet attempts to show JSP twice when there are no reports

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2, 3.0
    • Fix Version/s: 3.1
    • Component/s: JSPUI, Statistics
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      2

      Description

      The thread stating the problem starts here: http://www.mail-archive.com/dspace-tech@lists.sourceforge.net/msg20256.html
      Only dspace.log shows the stacktrace, not the UI.

      Due to a missing return statement, showJSP is executed twice if there are no report files present.

      first forward:
      https://github.com/DSpace/DSpace/blob/dspace-3.0/dspace-jspui/src/main/java/org/dspace/app/webui/servlet/StatisticsServlet.java#L168

      second forward:
      https://github.com/DSpace/DSpace/blob/dspace-3.0/dspace-jspui/src/main/java/org/dspace/app/webui/servlet/StatisticsServlet.java#L260

      a return statement after L168 should fix this

        Attachments

          Activity

            People

            Assignee:
            helix84 Ivan Masár
            Reporter:
            bram Bram Luyten (Atmire)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support