Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2012

JSPUI does not write column last_active in database as context is not commited after login

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0, 4.1, 4.2
    • Fix Version/s: 5.0
    • Component/s: DSpace API, JSPUI
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      8
    • Documentation Status:
      Not Required

      Description

      DS-1085 reports and fixes that the column last_active in the table eperson is never written. Using the JSPUI and authentication either by password or using shibboleth the last_active column is updated, but this update is not pushed into the database, as neither context.commit() nor context.complete() is called.

      It may be a little bit odd to call context.commit() in the JSPUI Servlet that handles the login, as the servlet does not change the database. But I think it is better to commit the context there then to commit it in the AuthenticationManager that belongs to dspace-api. Commiting a context in the AuthenticationManager could have bad side effects.

      Providing a fix should be easy, nevertheless I don't have the time right now. I probably will have the time by end of June if no one is faster...

      I did not checked the XMLUI but I would expect the same problem there.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pbecker Pascal-Nicolas Becker
              Reporter:
              pbecker Pascal-Nicolas Becker
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: