Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-2744

OAI is ignoring baseUrl

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0, 5.1, 5.2, 5.3
    • Fix Version/s: 5.4
    • Component/s: OAI-PMH
    • Environment:
      Ubuntu Server 14.04 / Oracle Java 7 (v80)
    • Attachments:
      0
    • Comments:
      3
    • Documentation Status:
      Not Required

      Description

      Systems that have a configuration variable for the base URL usually have it to gracefully handle situations like being behind a reverse proxy/balancer, etc. Otherwise, using the data that comes with the HTTP request should be enough for building URLs on the response.

      If you look at the code for DSpaceRepositoryConfiguration.java, you will notice the code tests for a configured baseUrl variable, and falls back to using the request header information. But it ommits actually reading the configuration, so it is always null. If you read at other functions they all read the configuration variable before checking its value.

      A PR will be send to patch this.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            tomascohen Tomás Cohen Arazi (UNC)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: