Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3819

Return 303 when Shibboleth redirect is needed

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.0
    • Fix Version/s: 7.0
    • Component/s: REST API v7
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      2
    • Documentation Status:
      Needed

      Description

      This is a follow up to https://github.com/DSpace/DSpace/pull/1927

      I've been thinking a bit more about this. What do you think about returning a 303 HTTP status code in case we also supply a Location header? That approach is more compliant with the HTTP protocol and prevents us from "abusing" the Location header. This shouldn't change the JavaScript implementation.

      In case authentication fails and we don't add the Location header (e.g. there is no method that provides a login URL), I would still return the 401.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tom.desair Tom Desair
              Reporter:
              terrywbrady Terrence W Brady
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support