Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-3874

Has File(s) options seem inconsistent

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Accepted / Claimed (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 6.0, 6.1, 6.2
    • Fix Version/s: None
    • Component/s: Language Packs
    • Labels:
      None
    • Environment:
      DSpace JSPUI
    • Attachments:
      0
    • Comments:
      2
    • Documentation Status:
      Not Required

      Description

      The Has File(s) filter has two options which indicate true|false, however, the user is presented the options "Yes|False". This change seems to originate from this PR: https://github.com/DSpace/DSpace/pull/988 it's unclear to me the reason behind this decision.

      Kim Shepherd and Mark H. Wood both agree that we should chose a convention for this, either "Yes|No" or "True|False".

      I think we should use "Yes|No" as it is more common to say than "True|False". Also, I updated the French translation to the equivalent of "Yes|No" in this PR: https://github.com/DSpace/dspace-api-lang/pull/27

      I welcome everyone's point of view for this.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            ptrottier Patrick Trottier
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated: