The “Approve item” button moves an item into archive although metadata that is required for the item is missing.
When an item is taken from the task pool, the reviewers have different options, e.g. with Workflow Step 3:
Return task to pool
The item can be approved without going through the submission input forms. Required metadata that should have been added during the workflow step is not present in the published item.
To reproduce the bug add this to input-forms:
<required>This field is required.</required>
Leave dc.identifier.isbn empty during submission, then approve the item without clicking “edit metadata” first. DSpace archives the item although the dc.identifier.isbn field is not present.
Suggestion for solutions:
A: The “Approve item” button is disabled unless the required metadata fields are present.
B: There is a warning when you try to approve an item where required metadata fields are missing.
The check for required metadata should consider type-bind to avoid the bug found in the curation task “requiredmetadata” (https://jira.duraspace.org/browse/DS-3896).