Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-4114

DSpace dismisses all GET parameters when changing language

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Code Review Needed (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 6.3, 5.10
    • Fix Version/s: None
    • Component/s: JSPUI
    • Labels:
      None
    • Attachments:
      0
    • Comments:
      0
    • Documentation Status:
      Needed

      Description

      When changing language in DSpace, all GET parameters of the current URL are dismissed and replace by the 'locale=<lang>' parameter. Relevant code: https://github.com/DSpace/DSpace/blob/9c16711dbef079e9eee55b660997b52adf487354/dspace-jspui/src/main/webapp/layout/navbar-default.jsp#L138

      This leads to odd behavior, since the language change dismisses current searches, etc., and can change the whole context

       

      Steps to reproduce:

      1. Execute a search in DSpace
      2. View search result
      3. Change language
      4. Search result is dismissed

       

      Solution:

      I've already created a pull request, which addresses this issue: https://github.com/DSpace/DSpace/pull/2285

      Instead of replacing all GET parameters when changing language, only the 'locale=<lang>' is added to the current URL or updated.

      The function responsible for this can be used with arbitrary GET parameters.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            r3r57 Cornelius Matějka
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: