Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-548

Removing repeatable values in DescribeStep does not properly test for authority control

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.6.1, 1.7.0
    • Component/s: DSpace API
    • Labels:
      None
    • Attachments:
      1
    • Comments:
      3
    • Documentation Status:
      Not Required

      Description

      Attempting to remove a repeatable parameter of input type "name" in DescribeStep causes the following exception to be thrown (exception only thrown in JSPUI, though the problem exists in org.dspace.submit.step.DescribeStep) unless that value is configured for authority control:

      ERROR org.dspace.app.webui.servlet.SubmissionController @ Error loading step class'org.dspace.submit.step.DescribeStep':
      java.lang.IndexOutOfBoundsException: Index: 1, Size: 0
      at java.util.LinkedList.entry(LinkedList.java:365)
      at java.util.LinkedList.remove(LinkedList.java:357)
      at org.dspace.submit.step.DescribeStep.readNames(DescribeStep.java:538)

      The linked list removals for "auth" and "conf" need to be wrapped in an if(isAuthorityControlled) test

      Similar problems exist in readText, and possibly other methods. Will submit a patch after some more testing.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kshepherd Kim Shepherd
              Reporter:
              kshepherd Kim Shepherd
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: