Uploaded image for project: 'DSpace'
  1. DSpace
  2. DS-834

CSV import dialog doesn't handle csv errors gracefully

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.8.0
    • Component/s: XMLUI
    • Labels:
      None
    • Attachments:
      1
    • Comments:
      3
    • Documentation Status:
      Not Required

      Description

      I was trying to upload a csv containing some metadata changes. In the upload dialog I all got was "no changes were detected" splash. It turned out that I had accidentally left some completely empty columns in the middle of the CSV file. Luckily I had a ssh screen running and it showed the stack trace below.

      It would be good to catch that exception and provide some guidance for the poor dspace admin trying to figure out what went wrong.

      java.lang.ArrayIndexOutOfBoundsException: 1
      at org.dspace.app.bulkedit.MetadataImport.compare(MetadataImport.java:345)
      at org.dspace.app.bulkedit.MetadataImport.runImport(MetadataImport.java:154)
      at org.dspace.app.xmlui.aspect.administrative.FlowMetadataImportUtils.processUploadCSV(FlowMetadataImportUtils.java:178)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:585)
      at org.mozilla.javascript.MemberBox.invoke(MemberBox.java:155)
      at org.mozilla.javascript.NativeJavaMethod.call(NativeJavaMethod.java:243)
      at org.mozilla.javascript.Interpreter.interpretLoop(Interpreter.java:3237)
      at org.mozilla.javascript.Interpreter.interpret(Interpreter.java:2394)
      at org.mozilla.javascript.InterpretedFunction.call(InterpretedFunction.java:162)
      at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:393)
      at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:2834)
      at org.mozilla.javascript.InterpretedFunction.call(InterpretedFunction.java:160)
      at org.mozilla.javascript.Context.call(Context.java:538)
      at org.mozilla.javascript.ScriptableObject.callMethod(ScriptableObject.java:1833)
      at org.mozilla.javascript.ScriptableObject.callMethod(ScriptableObject.java:1803)
      at org.apache.cocoon.components.flow.javascript.fom.FOM_JavaScriptInterpreter.handleContinuation(FOM_JavaScriptInterpreter.java:698)
      at org.apache.cocoon.components.treeprocessor.sitemap.CallFunctionNode.invoke(CallFunctionNode.java:94)
      at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:55)
      at org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke(MatchNode.java:87)
      at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:55)
      at org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke(MatchNode.java:87)

        Attachments

          Activity

            People

            Assignee:
            stuartlewis Stuart Lewis
            Reporter:
            tiaalto Timo Aalto
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: