Function naming causes function to be called as a hook

Solr facet pages contains old style function names beginning with underscores such as _islandora_solr_facet_pages_letterer (https://github.com/Islandora/islandora_solr_facet_pages/blob/7.x/islandora_solr_facet_pages.module#L136) and _islandora_solr_facet_pages_results (https://github.com/Islandora/islandora_solr_facet_pages/blob/7.x/islandora_solr_facet_pages.module#L202).

While normally these would be fine a situation can arise where they get invoked mistakenly when a theme call is ran due to the function naming matching: https://github.com/Islandora/islandora_solr_facet_pages/blob/7.x/islandora_solr_facet_pages.module#L66-L81. From a code smell/style perspective this kind of naming has been phased out as well.

-Steps to Reproduce-
Have a theme exist that extends a base theme such as zen, remove zen and watch the fireworks explode (happened on a client box).

Jordan Dukart
Developer
discoverygarden inc. | Managing Digital Content